Bug 300332 – WebKitWebExtension build failed on Clang

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Jamie Murphy]

> /host/home/jamie/Projects/Igalia/WebKit/Source/WebKit/UIProcess/Extensions/gtk/WebExtensionGtk.cpp:57:10: error: '__suffix' is an unsafe pointer used for buffer access [-Werror,-Wunsafe-buffer-usage]
>    57 |     if (!g_str_has_suffix(g_strdup(baseURL.get()), "/"))
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/glib-2.0/glib/gstrfuncs.h:187:27: note: expanded from macro 'g_str_has_suffix'
>   187 |        const char * const __suffix = (SUFFIX);                                \
>       |        ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
> /host/home/jamie/Projects/Igalia/WebKit/Source/WebKit/UIProcess/Extensions/gtk/WebExtensionGtk.cpp:57:10: note: used in pointer arithmetic here
>    57 |     if (!g_str_has_suffix(g_strdup(baseURL.get()), "/"))
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/glib-2.0/glib/gstrfuncs.h:198:34: note: expanded from macro 'g_str_has_suffix'
>   198 |                                  _G_STR_NONNULL (__suffix),                   \
>       |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/glib-2.0/glib/gstrfuncs.h:157:28: note: expanded from macro '_G_STR_NONNULL'
>   157 | #define _G_STR_NONNULL(x) ((x) + !(x))
>       |                            ^~~
> /host/home/jamie/Projects/Igalia/WebKit/Source/WebKit/UIProcess/Extensions/gtk/WebExtensionGtk.cpp:57:10: note: used in pointer arithmetic here
>    57 |     if (!g_str_has_suffix(g_strdup(baseURL.get()), "/"))
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/glib-2.0/glib/gstrfuncs.h:195:49: note: expanded from macro 'g_str_has_suffix'
>   195 |             const size_t __suffix_len = strlen (_G_STR_NONNULL (__suffix));   \
>       |                                                 ^~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/glib-2.0/glib/gstrfuncs.h:157:28: note: expanded from macro '_G_STR_NONNULL'
>   157 | #define _G_STR_NONNULL(x) ((x) + !(x))

[Jamie Murphy]

Pull request: https://github.com/WebKit/WebKit/pull/51953

[EWS]

Committed 301160@main (b523d2476326): <https://commits.webkit.org/301160@main>

Reviewed commits have been landed. Closing PR #51953 and removing active labels.