Bug 300260
| Summary: | ModelProcessModelPlayerManager.cpp:64:13: error: reference to stack memory associated with local variable 'modelProcessConnection' returned | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebXR | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | djg, kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 300272, 300201, 300268 | ||
| Bug Blocks: | |||
David Kilzer (:ddkilzer)
ModelProcessModelPlayerManager.cpp:64:13: error: reference to stack memory associated with local variable 'modelProcessConnection' returned.
Missed adding a call to `RefPtr::unsafeGet()` here:
```
Source/WebKit/WebProcess/Model/ModelProcessModelPlayerManager.cpp:64:13: error: reference to stack memory associated with local variable 'modelProcessConnection' returned [-Werror,-Wreturn-stack-address]
64 | return *modelProcessConnection;
| ^~~~~~~~~~~~~~~~~~~~~~
1 error generated.
```
<rdar://162066538>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/51893
EWS
Committed 301088@main (2da6c3d7fc14): <https://commits.webkit.org/301088@main>
Reviewed commits have been landed. Closing PR #51893 and removing active labels.
Karl Rackler
Reopened Bugzilla.
This reverts because it broke the build on the bots., tracking revert in https://bugs.webkit.org/show_bug.cgi?id=300272.