Bug 30026

Summary: [Chromium] Improve _NPN_SetException's handling of unexpected NPClass types
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch eric: review+

Nate Chapin
Reported 2009-10-02 13:15:59 PDT
Currently, if _NPN_SetException is passed any NPObject* not created from NPV8Object.cpp's npScriptObjectClass, it will exit early without actually throwing an exception. This check is to ensure that the NPObject* can be cast to an V8NPObject*, which we use to throw the exception in the relevant scope. Since both JSC and Mozilla appear to throw global exceptions, we should probably do the same if we can't find the right context.
Attachments
patch (1.63 KB, patch)
2009-10-02 13:20 PDT, Nate Chapin 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2009-10-02 13:20:19 PDT
Created attachment 40543 [details] patch
Eric Seidel (no email)
Comment 2 2009-10-02 15:38:29 PDT
Comment on attachment 40543 [details] patch So long as this is already tested, then this looks fine.
Note You need to log in before you can comment on or make changes to this bug.