Summary: | WebGL crashes with recent CanvasArray change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||||||||
Component: | WebGL | Assignee: | Kenneth Russell <kbr> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Blocker | CC: | cmarrin, dglazkov, kbr, oliver | ||||||||||
Priority: | P1 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Kenneth Russell
2009-10-02 08:34:11 PDT
Created attachment 40519 [details]
Patch
Created attachment 40520 [details]
Replacement patch eliminating stray tab
Comment on attachment 40520 [details]
Replacement patch eliminating stray tab
Can you add a testcase for this?
Created attachment 40526 [details]
Patch including test case
Added unit test. Verified that test crashes before fix and runs successfully after fix.
Comment on attachment 40526 [details] Patch including test case > +<html xmlns="http://www.w3.org/1999/xhtml"> we don't use namespaces -- tests should basically be html5 doctype if you want strict mode. But in this case you're also using the xml namespace which is also incorrect due to the file extension not being .xhtml, and not having an xml doctype :D And you need expected output Cheers, Oliver ... and don't forget -- WebKit style in JS also. 4-space, func brace on new line, etc. :) Created attachment 40533 [details]
Replacement patch with layouttest expected results
Comment on attachment 40533 [details]
Replacement patch with layouttest expected results
remove the superfluous namespace decl from <html> in the testcase
Sending LayoutTests/ChangeLog Adding LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt Adding LayoutTests/fast/canvas/webgl/array-unit-tests.html Sending WebCore/ChangeLog Sending WebCore/html/canvas/CanvasArray.cpp Transmitting file data ..... Committed revision 49027. |