Bug 30013

Summary:

Rename WebCore/css/mediaControlsQT.css and move mediaControls extras for the Qt port into WebCore/css

Product:

WebKit

Reporter:

Tor Arne Vestbø <vestbo>

Component:

CSS

Assignee:

Tor Arne Vestbø <vestbo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.6

Attachments:

Description	Flags
Move mediaControls extras for the Qt port into WebCore/css like other ports	eric.carlson: review+
Rename WebCore/css/mediaControlsQT.css and MediaControllerThemeQT	eric.carlson: review+

Tor Arne Vestbø

Reported 2009-10-02 03:49:53 PDT

The QT should be expanded to QuickTime, to not cause confusion and name-crashes with similar files in the Qt port.

Attachments
Move mediaControls extras for the Qt port into WebCore/css like other ports (10.04 KB, patch) 2009-10-02 03:51 PDT, Tor Arne Vestbø	eric.carlson: review+	Details Formatted Diff Diff
Rename WebCore/css/mediaControlsQT.css and MediaControllerThemeQT (18.43 KB, patch) 2009-10-02 03:51 PDT, Tor Arne Vestbø	eric.carlson: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tor Arne Vestbø

Comment 1 2009-10-02 03:51:48 PDT

Created attachment 40504 [details] Move mediaControls extras for the Qt port into WebCore/css like other ports

Tor Arne Vestbø

Comment 2 2009-10-02 03:51:56 PDT

Created attachment 40505 [details] Rename WebCore/css/mediaControlsQT.css and MediaControllerThemeQT

Tor Arne Vestbø

Comment 3 2009-10-02 03:53:51 PDT

(In reply to comment #2) > Created an attachment (id=40505) [details] > Rename WebCore/css/mediaControlsQT.css and MediaControllerThemeQT Messed up the order when attaching. This one should go first.

Eric Carlson

Comment 4 2009-10-02 10:12:09 PDT

Comment on attachment 40505 [details] Rename WebCore/css/mediaControlsQT.css and MediaControllerThemeQT WebKitLibraries/WebKitSystemInterface.h > > typedef enum { > WKMediaControllerThemeClassic = 1, > - WKMediaControllerThemeQT = 2 > + WKMediaControllerThemeQuickTime = 2 > } WKMediaControllerThemeStyle; Don't change this file directly, it must be changed in an internal project first or this change will be lost the next time WebKitSystemInterface is updated. I will fix this file. r=me without the WebKitSystemInterface.h change.

Eric Carlson

Comment 5 2009-10-02 10:12:17 PDT

Comment on attachment 40504 [details] Move mediaControls extras for the Qt port into WebCore/css like other ports r=me

Tor Arne Vestbø

Comment 6 2009-10-05 02:32:18 PDT

Thanks Eric! Landed in r49083 and r49087

Note You need to log in before you can comment on or make changes to this bug.