Bug 300035
| Summary: | Expose WebKit::NavigationActionData::isRequestFromClientOrUserInput through WKNavigationAction | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | New Bugs | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 266354 | ||
| Bug Blocks: | |||
Brent Fulgham
The NavigationActoinData class contains a flag that hints whether an action was triggered through User Input or a load directive from the User Agent Chrome (NavigationActionData::isRequestFromClientOrUserInput) (e.g., Bug 266354).
It would be helpful to expose this in the `WKNavigationAction` layer so that the User Interface could use this as a hint about how verbose to be during certain load failures. For example, a failed load of a custom URL scheme triggered by script while loading or updating a page doesn't generally need to be reported to the user, since they aren't aware of the load attempt and console logging will let a web developer see this. On the other hand, if a user clicks on a link or enters a URL in the browser chrome and the load fails, we want to immediately present this information so the user can understand what went wrong.
This patch exposes the existing WebKit::NavigationActionData::isRequestFromClientOrUserInput flag through the WKNavigationAction class so a client can access it. The data is already present in the UIProcess as internal state.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/161833541>
Brent Fulgham
Pull request: https://github.com/WebKit/WebKit/pull/51689
Brent Fulgham
*** Bug 300040 has been marked as a duplicate of this bug. ***
Brent Fulgham
This ended up not being necessary, so closing this.