Bug 299933
| Summary: | Call out the assumption in VM and VMEntryRecord that fields are loadable as a pair | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Vassili Bykov <v_bykov> |
| Component: | JavaScriptCore | Assignee: | Vassili Bykov <v_bykov> |
| Status: | RESOLVED FIXED | ||
| Severity: | Enhancement | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Vassili Bykov
VM::topCallFrame and VM::topEntryFrame are loaded as a pair by assembly code, so we assume they are consecutive and appear in that order. There is a similar pair of fields in VMEntryRecord. Let's put a comment in to warn about this assumption and prevent surprises (ask me how I know).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/161707462>
Vassili Bykov
Pull request: https://github.com/WebKit/WebKit/pull/51610
EWS
Committed 300898@main (8268f5fdf8eb): <https://commits.webkit.org/300898@main>
Reviewed commits have been landed. Closing PR #51610 and removing active labels.