Bug 299917
| Summary: | Enable BFCache by default in WebKitTestRunner for Navigation API tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | rupin |
| Component: | New Bugs | Assignee: | rupin |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
rupin
Multiple Navigation API tests require the BFCache. This is off by default in WKTR. So we copied the tests into the LayoutTests/https/wpt folder and added
<!-- webkit-test-runner [ UsesBackForwardCache=true ] -->
to make the tests run with the BFCache.
But in these tests, multiple URLs are still loaded with origins beginning with "web-platform.test:8800" as opposed to "localhost:8800". Rather than hardcode origins in these tests (bad in the long term as it would make importing/syncing more difficult), it would be better to just enable the BFCache for Navigation API tests.
Two of such tests that pass on WPT but fail locally since WKTR doesn't have BFCache on:
navigation-api/navigation-history-entry/entries-after-bfcache.html
navigation-api/per-entry-events/dispose-after-bfcache.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/161693746>
rupin
Pull request: https://github.com/WebKit/WebKit/pull/51663
EWS
Committed 300920@main (f1e512aef1b6): <https://commits.webkit.org/300920@main>
Reviewed commits have been landed. Closing PR #51663 and removing active labels.