Bug 299869
| Summary: | [Skia] Build a SkTextBlob when recording DrawGlyphs display list item | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> |
| Component: | Platform | Assignee: | Carlos Garcia Campos <cgarcia> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, ian.grunert, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Garcia Campos
GlyphDisplayListCache uses a display list to cache the shaping results of a text run that is frequently painted, but we are still building a SkTextBlob for the same shaping results every time the display list is replayed, which is expensive. We can build the SkTextBlob once when recording and save that in DrawGlyphs item instead of the list of glyphs and advances.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/51557
EWS
Committed 300818@main (7e98db0c73bf): <https://commits.webkit.org/300818@main>
Reviewed commits have been landed. Closing PR #51557 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/161720523>
Ian Grunert
This change is causing a crash on Windows:
https://bugs.webkit.org/show_bug.cgi?id=300412
Any ideas would be appreciated, it's a pretty unusual one.