Bug 299818 – [text shaping] Overflowing glyph gets clipped

• Component: New Bugs
• Status: RESOLVED FIXED

[alan]

ssia

[alan]

Created attachment 476897 [details]
Patch

[Antti Koivisto]

Comment on attachment 476897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=476897&action=review

> Source/WebCore/rendering/TextBoxPainter.cpp:672
> +    auto clipRect = [&] {
> +        // We could also just use ink overflow here but since non-range painting
> +        // sets up no clipping, we should not do that either here.
> +        auto rect = FloatRect::infiniteRect();
> +        rect.setX(m_paintRect.x());
> +        rect.setWidth(m_paintRect.width());
> +        return rect;
> +    };

Should the first and last box of a range only clip to one inline side?

[alan]

Created attachment 476902 [details]
Patch

[alan]

Created attachment 476906 [details]
[fast-cq]Patch

[EWS]

Committed 300823@main (bd08842b09e0): <https://commits.webkit.org/300823@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 476906 [details].

[Radar WebKit Bug Importer]

<rdar://problem/161728128>

[Radar WebKit Bug Importer]

<rdar://problem/161728177>