Bug 29974

Summary:

[V8] Recursion guard for V8Proxy::callFunction.

Product:

WebKit

Reporter:

Vitaly Repeshko <vitalyr>

Component:

WebCore Misc.

Assignee:

Vitaly Repeshko <vitalyr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none
patch: fixed ChangedLog formatting	dglazkov: review-, dglazkov: commit-queue-
patch: updated LayoutTest/ChangeLog	dglazkov: review-
patch: WebKit style in JS	dglazkov: review+, commit-queue: commit-queue-
updated patch v3	none

Description Vitaly Repeshko 2009-10-01 11:07:17 PDT

[V8] Recursion guard for V8Proxy::callFunction.

Comment 1 Vitaly Repeshko 2009-10-01 11:11:35 PDT

Created attachment 40462 [details]
patch

Comment 2 Vitaly Repeshko 2009-10-01 11:13:07 PDT

Created attachment 40463 [details]
patch: fixed ChangedLog formatting

Comment 3 Dimitri Glazkov (Google) 2009-10-01 11:24:47 PDT

Comment on attachment 40463 [details]
patch: fixed ChangedLog formatting

r=me.

Comment 4 Dimitri Glazkov (Google) 2009-10-01 11:25:19 PDT

Comment on attachment 40463 [details]
patch: fixed ChangedLog formatting

need LayoutTests/ChangeLog.

Comment 5 Vitaly Repeshko 2009-10-01 11:32:14 PDT

Created attachment 40464 [details]
patch: updated LayoutTest/ChangeLog

Comment 6 Dimitri Glazkov (Google) 2009-10-01 11:34:24 PDT

Comment on attachment 40464 [details]
patch: updated LayoutTest/ChangeLog

JS must be in WebKit style, too.

Comment 7 Vitaly Repeshko 2009-10-01 11:36:57 PDT

Created attachment 40465 [details]
patch: WebKit style in JS

Comment 8 Dimitri Glazkov (Google) 2009-10-01 11:39:23 PDT

Comment on attachment 40465 [details]
patch: WebKit style in JS

it's beautiful. r=me.

Comment 9 WebKit Commit Bot 2009-10-01 11:48:09 PDT

Comment on attachment 40465 [details]
patch: WebKit style in JS

Rejecting patch 40465 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11365 test cases.
fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html -> failed

Exiting early after 1 failures. 8281 tests run.
159.61s total testing time

8280 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
3 test cases (<1%) had stderr output

Comment 10 Dimitri Glazkov (Google) 2009-10-01 12:41:42 PDT

Well, it looks like vitalyr still has some work to do :)

Comment 11 Vitaly Repeshko 2009-10-02 14:37:52 PDT

Created attachment 40547 [details]
updated patch v3

Unfortunately V8 and JSC have to have slightly different expectations here.

Comment 12 Dimitri Glazkov (Google) 2009-10-02 15:05:48 PDT

Comment on attachment 40547 [details]
updated patch v3

ok.

Comment 13 WebKit Commit Bot 2009-10-02 15:15:41 PDT

Comment on attachment 40547 [details]
updated patch v3

Clearing flags on attachment: 40547

Committed r49047: <http://trac.webkit.org/changeset/49047>

Comment 14 WebKit Commit Bot 2009-10-02 15:15:50 PDT

All reviewed patches have been landed.  Closing bug.