Bug 29974

Summary:

[V8] Recursion guard for V8Proxy::callFunction.

Product:

WebKit

Reporter:

Vitaly Repeshko <vitalyr>

Component:

WebCore Misc.

Assignee:

Vitaly Repeshko <vitalyr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none
patch: fixed ChangedLog formatting	dglazkov: review-, dglazkov: commit-queue-
patch: updated LayoutTest/ChangeLog	dglazkov: review-
patch: WebKit style in JS	dglazkov: review+, commit-queue: commit-queue-
updated patch v3	none

Vitaly Repeshko

Reported 2009-10-01 11:07:17 PDT

[V8] Recursion guard for V8Proxy::callFunction.

Attachments
patch (3.27 KB, patch) 2009-10-01 11:11 PDT, Vitaly Repeshko	no flags	Details Formatted Diff Diff
patch: fixed ChangedLog formatting (3.27 KB, patch) 2009-10-01 11:13 PDT, Vitaly Repeshko	dglazkov: review- dglazkov: commit-queue-	Details Formatted Diff Diff
patch: updated LayoutTest/ChangeLog (3.92 KB, patch) 2009-10-01 11:32 PDT, Vitaly Repeshko	dglazkov: review-	Details Formatted Diff Diff
patch: WebKit style in JS (3.97 KB, patch) 2009-10-01 11:36 PDT, Vitaly Repeshko	dglazkov: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
updated patch v3 (3.96 KB, patch) 2009-10-02 14:37 PDT, Vitaly Repeshko	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Vitaly Repeshko

Comment 1 2009-10-01 11:11:35 PDT

Created attachment 40462 [details] patch

Vitaly Repeshko

Comment 2 2009-10-01 11:13:07 PDT

Created attachment 40463 [details] patch: fixed ChangedLog formatting

Dimitri Glazkov (Google)

Comment 3 2009-10-01 11:24:47 PDT

Comment on attachment 40463 [details] patch: fixed ChangedLog formatting r=me.

Dimitri Glazkov (Google)

Comment 4 2009-10-01 11:25:19 PDT

Comment on attachment 40463 [details] patch: fixed ChangedLog formatting need LayoutTests/ChangeLog.

Vitaly Repeshko

Comment 5 2009-10-01 11:32:14 PDT

Created attachment 40464 [details] patch: updated LayoutTest/ChangeLog

Dimitri Glazkov (Google)

Comment 6 2009-10-01 11:34:24 PDT

Comment on attachment 40464 [details] patch: updated LayoutTest/ChangeLog JS must be in WebKit style, too.

Vitaly Repeshko

Comment 7 2009-10-01 11:36:57 PDT

Created attachment 40465 [details] patch: WebKit style in JS

Dimitri Glazkov (Google)

Comment 8 2009-10-01 11:39:23 PDT

Comment on attachment 40465 [details] patch: WebKit style in JS it's beautiful. r=me.

WebKit Commit Bot

Comment 9 2009-10-01 11:48:09 PDT

Comment on attachment 40465 [details] patch: WebKit style in JS Rejecting patch 40465 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11365 test cases. fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html -> failed Exiting early after 1 failures. 8281 tests run. 159.61s total testing time 8280 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output

Dimitri Glazkov (Google)

Comment 10 2009-10-01 12:41:42 PDT

Well, it looks like vitalyr still has some work to do :)

Vitaly Repeshko

Comment 11 2009-10-02 14:37:52 PDT

Created attachment 40547 [details] updated patch v3 Unfortunately V8 and JSC have to have slightly different expectations here.

Dimitri Glazkov (Google)

Comment 12 2009-10-02 15:05:48 PDT

Comment on attachment 40547 [details] updated patch v3 ok.

WebKit Commit Bot

Comment 13 2009-10-02 15:15:41 PDT

Comment on attachment 40547 [details] updated patch v3 Clearing flags on attachment: 40547 Committed r49047: <http://trac.webkit.org/changeset/49047>

WebKit Commit Bot

Comment 14 2009-10-02 15:15:50 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.