Bug 299682
| Summary: | Replace overload based resolution of the canvas inspector argument tracer with resolution using explicit IDLType specialization | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | Bindings | Assignee: | Sam Weinig <sam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 18 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Weinig
The overload based resolution for the of the canvas inspector argument tracing code driven by the big macro in InspectorCanvasCallTracer.h is pretty easy to break due to its use of overloading to differentiate argument types. The most common issue is accidentally making types get treated as `bool`.
We can do better using templates!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/51458
EWS
Committed 300666@main (37ee1bd3a1c7): <https://commits.webkit.org/300666@main>
Reviewed commits have been landed. Closing PR #51458 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/161522149>
Radar WebKit Bug Importer
<rdar://problem/161522120>