Bug 29967

Summary: clicking the text in a "Request Payload" section in Resource panel causes text to disappear
Product: WebKit Reporter: Patrick Mueller <pmuellr>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: aroben, commit-queue, jeroen.bensch, kmccullough, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
proposed patch - 2009/10/02 - 1 none

Description Patrick Mueller 2009-10-01 09:49:48 PDT
From Bug 29935, comment 5 :


   This loads a .swf.

   In Web Inspector's Resources select the execBatch one, expand Request Payload and click on the revealed text. It's gone.
Comment 1 Patrick Mueller 2009-10-01 09:51:23 PDT
Note the text is still there.  You can swipe it with the mouse and see it.  Styled to white for some reason.

Note also any work going on for Bug 29955 may affect this.
Comment 2 Patrick Mueller 2009-10-02 10:00:10 PDT
Created attachment 40531 [details]
proposed patch - 2009/10/02 - 1

simple fix - the tree element was "selectable".  making it not selectable keeps the text from disappearing.  Note, "selectable" is a tree thing - the text in the request payload is still swipe-able (for copy/paste)
Comment 3 WebKit Commit Bot 2009-10-02 12:34:19 PDT
Comment on attachment 40531 [details]
proposed patch - 2009/10/02 - 1

Rejecting patch 40531 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11370 test cases.
transitions/transition-end-event-transform.html -> failed

Exiting early after 1 failures. 11304 tests run.
355.51s total testing time

11303 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
6 test cases (<1%) had stderr output
Comment 4 Patrick Mueller 2009-10-02 14:45:13 PDT
New to commit bot errors.  Seems like there is no way the patch I uploaded would actually cause the problem reported (but ANYTHING is possible of course).

What should I do next?
Comment 5 Eric Seidel (no email) 2009-10-02 15:12:26 PDT
Comment on attachment 40531 [details]
proposed patch - 2009/10/02 - 1

Not your fault.  I filed bug 30029 and have marked this cq+ again.
Comment 6 WebKit Commit Bot 2009-10-02 15:23:43 PDT
Comment on attachment 40531 [details]
proposed patch - 2009/10/02 - 1

Clearing flags on attachment: 40531

Committed r49048: <http://trac.webkit.org/changeset/49048>
Comment 7 WebKit Commit Bot 2009-10-02 15:23:46 PDT
All reviewed patches have been landed.  Closing bug.