Bug 299656
| Summary: | [GStreamer] Build broken when using GStreamer 1.27.2 built from tarballs | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | dueffert |
| Component: | New Bugs | Assignee: | Philippe Normand <philn> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | philn, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | All | ||
| OS: | All | ||
dueffert
Commit 77738c8819ec805909deb441764c0a4a72309809 introduces using gst_pad_probe_info_set_buffer, which according to gstreamer documentation will be in version 1.28 of gstreamer. But it was only added to gstreamer git September 9th, i.e. 2 days after their latest development release 1.27.2 . There are related GST_CHECK_VERSIONs in above commit, but they check for version 1.27.0 - which does not contain gst_pad_probe_info_set_buffer yet. Changing those 2 checks to e.g. GST_CHECK_VERSION(1, 28, 0) allows me to compile webkitgtk-2.50.0 and and webkitgetk-2.48.7 both containing the commit in question.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Philippe Normand
There is no 1.28.0 release yet, so changing those ifdefs to 1.28.0 isn't right imho. Until then, if you have a gstreamer git checkout it is your responsibility to keep it up-to-date.
When 1.28.0 is released, the ifdefs will be updated accordingly :)
dueffert
I'm not sure either whether GST_CHECK_VERSION(1, 28, 0) would be right. Just an assumption based on their claim "Since 1.28" in https://gstreamer.freedesktop.org/documentation/gstreamer/gstpad.html . Maybe GST_CHECK_VERSION(1, 27, 3) will turn out to be more correct. I agree that it would be my responsibility to keep some gstreamer git checkout uptodate. But I never had one and do not intent to change that. Instead, I used their released gstreamer-1.27.2 - and that does not contain gst_pad_probe_info_set_buffer yet, so IMHO GST_CHECK_VERSION(1, 27, 0) is clearly wrong...
Philippe Normand
Ah sorry I thought you were using a gstreamer git checkout.
Maybe changing the ifdefs to "GST_CHECK_VERSION(1, 27, 3) || GST_CHECK_VERSION(1, 28, 0)" would work then?
Philippe Normand
Might break with current gstreamer git checkouts where the version is 1.27.2.1 though... i can take a look this week...
Philippe Normand
Oh right, the "#9 SkSafeUnref<GrDirectContext> (obj=0x1)" looks fun.
Philippe Normand
Pull request: https://github.com/WebKit/WebKit/pull/51492
EWS
Committed 300744@main (61a456e19153): <https://commits.webkit.org/300744@main>
Reviewed commits have been landed. Closing PR #51492 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/161631856>