Bug 29953

Summary: [GTK] video sink pad template colorspace is wrong
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, slomo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch none

Description Philippe Normand 2009-10-01 00:12:12 PDT 
As pointed out by slomo, our sink suports xRGB and BGRx always. Cairo doesn't.
CAIRO_FORMAT_RGB24 is xRGB on big endian machines, and BGRx on little
endian.

So this should really be
#if G_BYTE_ORDER == G_LITTLE_ENDIAN
  GST_VIDEO_CAPS_BGRx
#else
  GST_VIDEO_CAPS_xRGB
#endif
Comment 1 Philippe Normand 2009-10-01 06:22:49 PDT 
Created attachment 40437 [details]
proposed patch
Comment 2 Gustavo Noronha (kov) 2009-10-01 08:59:03 PDT 
Comment on attachment 40437 [details]
proposed patch

Hmm. I tried to read some documentation about this problem, but could not find any useful stuff in a quick search. Looks correct to me, though.
Comment 3 WebKit Commit Bot 2009-10-01 10:09:43 PDT 
Comment on attachment 40437 [details]
proposed patch

Clearing flags on attachment: 40437

Committed r48979: <http://trac.webkit.org/changeset/48979>
Comment 4 WebKit Commit Bot 2009-10-01 10:09:46 PDT 
All reviewed patches have been landed.  Closing bug.