Bug 29949

Summary:

set ENABLE_NOTIFICATIONS=1 for Chromium

Product:

WebKit

Reporter:

John Gregg <johnnyg>

Component:

WebKit Misc.

Assignee:

John Gregg <johnnyg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	dglazkov: review+, commit-queue: commit-queue-

John Gregg

Reported 2009-09-30 19:30:34 PDT

Part of adding desktop notifications support to chromium means setting this flag. This is a 2-sided patch, and needs to land concurrently with http://codereview.chromium.org/194079/show.

Attachments
patch (989 bytes, patch) 2009-09-30 19:36 PDT, John Gregg	dglazkov: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

John Gregg

Comment 1 2009-09-30 19:36:22 PDT

Created attachment 40418 [details] patch

Dimitri Glazkov (Google)

Comment 2 2009-10-01 13:47:13 PDT

Comment on attachment 40418 [details] patch rs=me.

John Gregg

Comment 3 2009-10-06 14:31:54 PDT

Comment on attachment 40418 [details] patch No longer 2-sided since the flag is already set in features_override.gypi. Adding to the commit queue.

WebKit Commit Bot

Comment 4 2009-10-06 14:36:42 PDT

Comment on attachment 40418 [details] patch Rejecting patch 40418 from commit-queue. johnnyg@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.

WebKit Commit Bot

Comment 5 2009-10-06 16:32:46 PDT

Comment on attachment 40418 [details] patch Rejecting patch 40418 from commit-queue. Patch https://bugs.webkit.org/attachment.cgi?id=40418 from bug 29949 failed to download and apply.

Adam Barth

Comment 6 2009-10-19 21:02:08 PDT

Committed r49834: <http://trac.webkit.org/changeset/49834>

Note You need to log in before you can comment on or make changes to this bug.