Bug 299262 – REGRESSION(300282@main): WPEDisplayDRM.cpp:379:23: warning: format ‘%s’ expects argument of type ‘char*’, but argument 5 has type ‘std::span<const WTF::Latin1Character>::pointer’ {aka ‘const WTF::Latin1Character*’} [-Wformat=]

• Component: WPE WebKit
• Status: RESOLVED FIXED

[Fujii Hironori]

REGRESSION(300282@main): WPEDisplayDRM.cpp:379:23: warning: format ‘%s’ expects argument of type ‘char*’, but argument 5 has type ‘std::span<const WTF::Latin1Character>::pointer’ {aka ‘const WTF::Latin1Character*’} [-Wformat=]

[2745/9702] Building CXX object Source/WebKit/WPEPlatform/wpe/drm/CMakeFiles/WPEPlatformDRM.dir/WPEDisplayDRM.cpp.o
In file included from /usr/include/glib-2.0/glib.h:64,
                 from /usr/include/glib-2.0/gobject/gbinding.h:30,
                 from /usr/include/glib-2.0/glib-object.h:24,
                 from /home/fujii/webkit/wa/Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.h:34,
                 from /home/fujii/webkit/wa/Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp:27:
/home/fujii/webkit/wa/Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp: In function ‘gboolean wpeDisplayDRMSetup(WPEDisplayDRM*, const char*, GError**)’:
/home/fujii/webkit/wa/Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp:379:23: warning: format ‘%s’ expects argument of type ‘char*’, but argument 5 has type ‘std::span<const WTF::Latin1Character>::pointer’ {aka ‘const WTF::Latin1Character*’} [-Wformat=]
  379 |             g_warning("Invalid WPE_DRM_SCALE='%*s' value, or out of bounds.", static_cast<int>(scaleString.span8().size()), scaleString.span8().data());
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                                                                                                     |
      |                                                                                                                                                     std::span<const WTF::Latin1Character>::pointer {aka const WTF::Latin1Character*}
/home/fujii/webkit/wa/Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp:379:49: note: format string is defined here
  379 |             g_warning("Invalid WPE_DRM_SCALE='%*s' value, or out of bounds.", static_cast<int>(scaleString.span8().size()), scaleString.span8().data());
      |                                               ~~^
      |                                                 |
      |                                                 char*

[Fujii Hironori]

Pull request: https://github.com/WebKit/WebKit/pull/51090

[EWS]

Committed 300311@main (133ec45a0d82): <https://commits.webkit.org/300311@main>

Reviewed commits have been landed. Closing PR #51090 and removing active labels.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 299310

[Alexey Proskuryakov]

The offending commit was reverted. I see that the new PR includes changes to WPEDisplayDRM.cpp, so all should continue to be good.