Bug 299189
| Summary: | REGRESSION(300173@main): Pixel tolerance for WPT tests under /css/filter-effects/filter-function was increased to make them useless | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Layout and Rendering | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=299063 | ||
| Bug Depends on: | |||
| Bug Blocks: | 243816 | ||
Said Abou-Hallawa
The problem was the change in these tests:
imported/w3c/web-platform-tests/css/filter-effects/filter-function/filter-function-repeating-radial-gradient.html
imported/w3c/web-platform-tests/css/filter-effects/filter-function/filter-function-repeating-conic-gradient.html
After 300173@main, most of the pixels were changed in the actual image by just one in only one channel. For example white pixel (0xFF, 0XFF, 0XFF) became (0xFF, 0XFF, 0XFE). That is okay but the problem is at the edges of the conic and radial gradients, some pixels are changed by 255 in one channel. The number of these pixels is not large so the pixel difference was something like 0.29% . But the pixel tolerance had to be something like this:
<meta name="fuzzy" content="maxDifference=0-255; totalPixels=0-107939">
which made the test almost useless. Any regression will not be discoverable with large pixel tolerance.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/160949031>
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/51016
Said Abou-Hallawa
Bug 299228 addresses this issue better than this bug. It does not change the WPT tests and it removes the pixel tolerance completely.
*** This bug has been marked as a duplicate of bug 299228 ***