Bug 29894

Summary:

[CHROMIUM] Fix Chromium build following r48884

Product:

WebKit

Reporter:

Stephen White <senorblanco>

Component:

WebCore JavaScript

Assignee:

Stephen White <senorblanco>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Fix for Chromium build break.	eric: review-

Stephen White

Reported 2009-09-29 13:36:45 PDT

Need to update the V8 side after r48884, ap@apple.com's change for JS event listeners.

Attachments
Fix for Chromium build break. (3.07 KB, patch) 2009-09-29 13:54 PDT, Stephen White	eric: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Stephen White

Comment 1 2009-09-29 13:54:02 PDT

Created attachment 40322 [details] Fix for Chromium build break.

Dimitri Glazkov (Google)

Comment 2 2009-09-29 13:59:49 PDT

This is almost there -- need the same changes for V8WorkerContextEventListener and V8WorkerContextObjectEventListener.

Eric Seidel (no email)

Comment 3 2009-09-29 14:10:07 PDT

Comment on attachment 40322 [details] Fix for Chromium build break. These are unrelated changes, they should be separate commits. You can commit your addition to committers.py w/o review assuming you actually have commit privs by now (which I would expect you do). The build fix also can be committed w/o review, assuming it's just a build fix. Review is always nicer, but not required for build fixes.

Dimitri Glazkov (Google)

Comment 4 2009-09-29 14:12:48 PDT

I asked to upload patch, so that I could take a look.

Stephen White

Comment 5 2009-09-30 08:15:25 PDT

This was committed as r48904 and can be closed.

Note You need to log in before you can comment on or make changes to this bug.