Bug 298479

Summary:	TZoneHeapManager::init() should use CC_SHA256_DIGEST_LENGTH for its CC_SHA256 seed size.
Product:	WebKit	Reporter:	Mark Lam <mark.lam>
Component:	bmalloc	Assignee:	Mark Lam <mark.lam>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ggaren, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Mark Lam

Reported 2025-09-05 15:29:48 PDT

CC_SHA256_DIGEST_LENGTH is 32 bytes in size. It was previously allocating CC_SHA1_DIGEST_LENGTH which is 20 bytes in size. However, disassembly of the function shows that this bug is benign: that extra 12 bytes of stack memory written to by CC_SHA256 is unused. Regardless, we'll fix this.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2025-09-05 15:30:21 PDT

<rdar://problem/159973958>

Mark Lam

Comment 2 2025-09-05 15:39:12 PDT

Pull request: https://github.com/WebKit/WebKit/pull/50394

EWS

Comment 3 2025-09-06 15:17:59 PDT

Committed 299666@main (b386e6352b37): <https://commits.webkit.org/299666@main> Reviewed commits have been landed. Closing PR #50394 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.