Bug 298164
| Summary: | Skip Wasm tests in run-javascriptcore-tests and run-jsc-stress-tests when Wasm is not enabled. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Lam
This patch changes the following:
1. In run-javascriptcore-tests, skip wasm.yaml wholesale if Wasm is not supported.
2. In run-jsc-stress-tests, skip any tests that have "wasm-" or "-wasm" in the test name if Wasm is not supported.
3. Move some tests that are only relevant for Wasm from JSTests/stress to JSTests/wasm/stress/.
With these changes, CLoop builds no longer run nor fail wasm tests without us needing to manually add skip statements or explicit checks for the WebAssembly object in the tests.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/159541255>
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/50113
EWS
Committed 299431@main (25747ea0ed52): <https://commits.webkit.org/299431@main>
Reviewed commits have been landed. Closing PR #50113 and removing active labels.