Bug 298113
| Summary: | [Style] Replace FillLayer linked list with strong style typed fixed vector | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | CSS | Assignee: | Sam Weinig <sam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ddkilzer, koivisto, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 18 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=297439 https://bugs.webkit.org/show_bug.cgi?id=302533 |
||
| Bug Depends on: | |||
| Bug Blocks: | 298883 | ||
Sam Weinig
Replacing the FillLayer linked list with strong style typed fixed vector is both more efficient for larger lists and a bit more idiomatic.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/50078
EWS
Committed 299407@main (9c502fcf9c71): <https://commits.webkit.org/299407@main>
Reviewed commits have been landed. Closing PR #50078 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/159619297>
David Kilzer (:ddkilzer)
Hi Sam, this change regressed this fix made to Source/WebCore/rendering/style/FillLayer.h:
Fix -Wpreferred-type-bitfield-enum-conversion warnings in WebCore
<https://bugs.webkit.org/show_bug.cgi?id=297439>
<rdar://158245532>
<https://commits.webkit.org/298737@main>
(It's only caught by newer versions of clang, which is why builds didn't fail.)
David Kilzer (:ddkilzer)
<rdar://159619297>