Bug 29790

Summary: REGRESSION(r48701): Google Reader's Manage Subscriptions link fails to work
Product: WebKit Reporter: Jubal Kessler <jubal-webkit-20111123>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, ggaren, jeff.pitman, sam
Priority: P2 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.6   
URL: http://reader.google.com
Attachments:
Description Flags
Screenshot of truncated settings page. none

Jubal Kessler
Reported 2009-09-27 16:09:56 PDT
Created attachment 40208 [details] Screenshot of truncated settings page. Log into Google Reader, and in the lower left corner, click on the "Manage Subscriptions" link. The link fails to work as expected, e.g. no settings page appears. The "loading" throbber or whatchamacallit animation runs for a bit, then stops, and the status quo remains, e.g. no change, nothing, nada. So does the normal "Settings" link (upper right corner, to the right of the logged-in user/email string). Attempting to visit the settings URL directly for Google Reader results in a truncated page: http://www.google.com/reader/settings?display=edit-subscriptions (screenshot attached of truncated settings page) Safari 4.0.3, nightly build 48794. Safari 4.0.4 (vanilla) works just fine. Firefox 3.5 has no issue with either of the above. This is the first time I can remember WebKit failing to work in Google Reader for the settings page, so I think it may be a recent regression. Please choose the correct component for me -- I do not know which is the most suitable. Thanks!
Attachments
Screenshot of truncated settings page. (25.83 KB, image/png)
2009-09-27 16:09 PDT, Jubal Kessler 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Jeff Pitman
Comment 1 2009-10-12 06:34:26 PDT
Still a problem in Version 4.0.3 (5531.9, r49412).
Dimitri Glazkov (Google)
Comment 2 2009-10-12 08:56:36 PDT
Hearing that this is a result of of http://trac.webkit.org/changeset/48701, not sure yet. Adding relevant folks.
Geoffrey Garen
Comment 3 2009-10-12 12:22:58 PDT
Hmmm.... Can't reproduce this bug with Safari 4.0.3, nightly build 49276. Can anyone else reproduce this?
Dimitri Glazkov (Google)
Comment 4 2009-10-12 12:27:42 PDT
I can repro on r49434.
Dimitri Glazkov (Google)
Comment 5 2009-10-12 12:32:05 PDT
Clicking on "Settings" takes you to settings page on r48680, but not on r48730.
Geoffrey Garen
Comment 6 2009-10-12 14:02:05 PDT
I can reproduce this now. Not sure what I was doing wrong before :(.
Mark Rowe (bdash)
Comment 7 2009-10-20 12:55:40 PDT
<rdar://problem/7319905>
Mark Rowe (bdash)
Comment 8 2009-10-20 13:50:15 PDT
A user on Twitter mentioned that this was introduced between r48199 and r48276. We need to confirm this and double-check whether Dimitri’s suggested revision is in fact the culprit.
Mark Rowe (bdash)
Comment 9 2009-10-20 16:56:56 PDT
Confirmed that this is a result of r48701.
Dimitri Glazkov (Google)
Comment 10 2009-10-23 11:29:45 PDT
Working on this and taking it. Geoffrey, if you're cooking a fix, too -- let me know.
Mark Rowe (bdash)
Comment 11 2009-10-25 18:17:22 PDT
Bug 30761 also appears to have been caused by r48701. Once this Reader bug is resolved we should verify whether it still occurs and decide whether to dupe it against this bug.
Dimitri Glazkov (Google)
Comment 12 2009-10-26 15:17:00 PDT
Fixed in http://trac.webkit.org/changeset/50100.
Note You need to log in before you can comment on or make changes to this bug.