| Summary: | Share code in HTMLInputElement and HTMLTextAreaElement | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
| Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Trivial | CC: | adele, commit-queue, eric | ||||
| Priority: | P4 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | 28703 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Kent Tamura
2009-09-27 09:31:13 PDT
Created attachment 40193 [details]
Proposed patch
This patch will remove 160 lines and add 100 lines exclude ChangeLog change.
Comment on attachment 40193 [details]
Proposed patch
Looks fine to me. I could have sworn I already reviewed this patch on a different bug.
Comment on attachment 40193 [details]
Proposed patch
Rejecting patch 40193 from commit-queue.
Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11370 test cases.
dom/html/level2/html/HTMLFrameElement01.html -> crashed
Exiting early after 1 failures. 1267 tests run.
210.43s total testing time
1266 test cases (99%) succeeded
1 test case (<1%) crashed
1 test case (<1%) had stderr output
Comment on attachment 40193 [details] Proposed patch I've filed bug 30030 about this failure. I don't believe this was related to your changes. Comment on attachment 40193 [details] Proposed patch Clearing flags on attachment: 40193 Committed r49051: <http://trac.webkit.org/changeset/49051> All reviewed patches have been landed. Closing bug. |