Bug 297756
| Summary: | text-decoration-line: Refactor TextDecorationLine into strong type | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Vitor Roriz <vitor.roriz> |
| Component: | CSS | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Vitor Roriz
text-decoration-line: Refactor TextDecorationLine into strong type
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/158897260>
Vitor Roriz
Pull request: https://github.com/WebKit/WebKit/pull/49738
EWS
Committed 299142@main (b0dc25a5f71e): <https://commits.webkit.org/299142@main>
Reviewed commits have been landed. Closing PR #49738 and removing active labels.
Diego Pino
Linux build bots building with GCC12 or lower, failed with the following error:
error: call to non-‘constexpr’ function ‘bool WebCore::Style::TextDecorationLine::isNone() const’
134 | constexpr explicit operator bool() const { return !isNone(); }
| ~~~~~~^~
/home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebCore/PrivateHeaders/WebCore/StyleTextDecorationLine.h:71:10: note: ‘bool WebCore::Style::TextDecorationLine::isNone() const’ declared here
71 | bool isNone() const { return WTF::holdsAlternative<CSS::Keyword::None>(m_value); }
| ^~~~~~
Diego Pino
Re-opening for pull request https://github.com/WebKit/WebKit/pull/49885
EWS
Committed 299190@main (45e657c98e41): <https://commits.webkit.org/299190@main>
Reviewed commits have been landed. Closing PR #49885 and removing active labels.