Bug 29760

Summary:

Implement CSSOM Range.getClientRects/getBoundingClientRect

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
WIP Patch	none
patch	mitz: review+

Sam Weinig

Reported 2009-09-25 22:19:15 PDT

Created attachment 40161 [details] WIP Patch We should implement CSSOM Range.getClientRects/getBoundingClientRect (http://www.w3.org/TR/2009/WD-cssom-view-20090804/) to complement Element.getClientRects/getBoundingClientRect.

Attachments
WIP Patch (9.75 KB, patch) 2009-09-25 22:19 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
patch (90.44 KB, patch) 2009-09-27 14:54 PDT, Sam Weinig	mitz: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2009-09-25 22:20:32 PDT

The attached patch works, but I am not happy with how I determined if the parent node was in the Range. It obviously also needs tests.

Sam Weinig

Comment 2 2009-09-27 14:54:53 PDT

Created attachment 40207 [details] patch

mitz

Comment 3 2009-09-27 15:03:30 PDT

Comment on attachment 40207 [details] patch > + IntRect result = quads[0].enclosingBoundingBox(); > + for (size_t i = 1; i < quads.size(); ++i) > + result.unite(quads[i].enclosingBoundingBox()); There is no need to special-case the first rect.

Sam Weinig

Comment 4 2009-09-27 16:59:31 PDT

Landed in r48806.

Note You need to log in before you can comment on or make changes to this bug.