Bug 29758

Summary:

Code generator does not support custom constructor getters in V8

Product:

WebKit

Reporter:

Andrew Wilson <atwilson>

Component:

WebCore JavaScript

Assignee:

Andrew Wilson <atwilson>

Status:

RESOLVED INVALID

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
proposed patch	none

Andrew Wilson

Reported 2009-09-25 18:02:27 PDT

Need to update the code generator to support custom getters for constructors in V8, so we can properly support turning on/off APIs at runtime via command line flags.

Attachments
proposed patch (5.59 KB, patch) 2009-09-27 14:06 PDT, Andrew Wilson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrew Wilson

Comment 1 2009-09-27 14:06:18 PDT

Created attachment 40206 [details] proposed patch This patch just enables custom constructors for V8, but none of the existing code requires a custom constructor. My upcoming patch to turn on the ENABLE_SHARED_WORKERS flag for Chromium will include custom constructors - this patch is a prelude to that.

Andrew Wilson

Comment 2 2009-09-27 14:07:14 PDT

Successful trybot run: http://build.chromium.org/buildbot/try-server/builders/layout_mac/builds/39

Andrew Wilson

Comment 3 2009-10-01 16:10:58 PDT

Closing - made obsolete by http://trac.webkit.org/changeset/48955

Eric Seidel (no email)

Comment 4 2009-10-02 12:30:29 PDT

Comment on attachment 40206 [details] proposed patch Clearing review flag on closed bug.

Note You need to log in before you can comment on or make changes to this bug.