Bug 29734

Summary:

Enable Pasteboard::writePlainText for Chromium and fix code style nits

Product:

WebKit

Reporter:

Alexander Pavlov (apavlov) <apavlov>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, mitz, pfeldman

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	mitz: review-
patch (condition fixed)	mitz: review+

Description Alexander Pavlov (apavlov) 2009-09-25 03:59:52 PDT

The associated patch shall uncomment the method body for the Chromium platform (introduced in https://bugs.webkit.org/show_bug.cgi?id=29634) now that the necessary Chromium repository change is in place, and fix some leftover style nits.

Comment 1 Alexander Pavlov (apavlov) 2009-09-25 06:36:41 PDT

Created attachment 40108 [details]
patch

Comment 2 mitz 2009-09-25 07:09:22 PDT

Comment on attachment 40108 [details]
patch

> -    if (types == nil) {
> +    if (!types == nil) {

This is wrong. I think you meant to change (types == nil) to (!types).

Comment 3 Alexander Pavlov (apavlov) 2009-09-25 07:24:38 PDT

Created attachment 40110 [details]
patch (condition fixed)

Apologies, I somehow failed to delete the rest of the condition. This is now fixed.

Comment 4 Pavel Feldman 2009-09-25 08:48:11 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/chromium/PasteboardChromium.cpp
	M	WebCore/platform/gtk/PasteboardGtk.cpp
	M	WebCore/platform/mac/PasteboardMac.mm
	M	WebCore/platform/qt/PasteboardQt.cpp
Committed r48755