Bug 29734

Summary: Enable Pasteboard::writePlainText for Chromium and fix code style nits
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mitz, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
mitz: review-
patch (condition fixed) mitz: review+

Alexander Pavlov (apavlov)
Reported 2009-09-25 03:59:52 PDT
The associated patch shall uncomment the method body for the Chromium platform (introduced in https://bugs.webkit.org/show_bug.cgi?id=29634) now that the necessary Chromium repository change is in place, and fix some leftover style nits.
Attachments
patch (5.60 KB, patch)
2009-09-25 06:36 PDT, Alexander Pavlov (apavlov) 		mitz: review-
DetailsFormatted DiffDiff
patch (condition fixed) (5.60 KB, patch)
2009-09-25 07:24 PDT, Alexander Pavlov (apavlov) 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2009-09-25 06:36:41 PDT
Created attachment 40108 [details] patch
mitz
Comment 2 2009-09-25 07:09:22 PDT
Comment on attachment 40108 [details] patch > - if (types == nil) { > + if (!types == nil) { This is wrong. I think you meant to change (types == nil) to (!types).
Alexander Pavlov (apavlov)
Comment 3 2009-09-25 07:24:38 PDT
Created attachment 40110 [details] patch (condition fixed) Apologies, I somehow failed to delete the rest of the condition. This is now fixed.
Pavel Feldman
Comment 4 2009-09-25 08:48:11 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/chromium/PasteboardChromium.cpp M WebCore/platform/gtk/PasteboardGtk.cpp M WebCore/platform/mac/PasteboardMac.mm M WebCore/platform/qt/PasteboardQt.cpp Committed r48755
Note You need to log in before you can comment on or make changes to this bug.