Bug 297265
| Summary: | WTF assertions need to use C compliant assembly | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | adrian_taylor |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
adrian_taylor
Parts of wtf/Assertions.h are available in non C++ contexts and in some downstream consumers of WebKit are not compiled with GNU extensions, so these parts must not use 'asm' but instead '__asm__'. This problem has become apparent due to the use of clang modules which compile the entire file to an AST and thus reveal compilation errors even if these macros are not actually used.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
adrian_taylor
<rdar://problem/157617570>
adrian_taylor
Pull request: https://github.com/WebKit/WebKit/pull/49264
EWS
Committed 298649@main (2b1e2b76fea8): <https://commits.webkit.org/298649@main>
Reviewed commits have been landed. Closing PR #49264 and removing active labels.