Bug 29721 – add a gyp variable to allow compiling webcore without debug symbols

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Tony Chang]

Compiling a debug chromium with a webcore that doesn't have debug symbols cuts the output binary from ~750mb to ~350mb.  This speeds up the compile and reduces the gdb startup time considerably.

It would be nice to have a gyp variable for this.

[Tony Chang]

Created attachment 40078 [details]
v1

[Tony Chang]

Mark: Can you take a look at this change?

[Mark Mentovai]

Comment on attachment 40078 [details]
v1

This change looks good to me, but you should be aware that it won't be effective on the Mac, because we don't turn on debugging symbols by setting cflags.

[Mark Mentovai]

I'm somewhat surprised that Bugzilla allowed me to formally r+ this, since I'm not a WebKit reviewer.  I'm not sure what WebKit reviewer would be appropriate here though.  I just mention this so that you can cover your bases.

[David Levin]

Comment on attachment 40078 [details]
v1

Changing back to r? so I can r+ it.

[David Levin]

Comment on attachment 40078 [details]
v1

r=me (since Mark said it looked good.)

I'll leave the cq?. Tony since you are a committer you can change it to cq+ if you want to try to use the auto-commit thing.

[Tony Chang]

Comment on attachment 40078 [details]
v1

Let's try the auto committer.

[WebKit Commit Bot]

Comment on attachment 40078 [details]
v1

Rejecting patch 40078 from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.

[Eric Seidel (no email)]

Comment on attachment 40078 [details]
v1

Looks like tony hasn't added himself to the committers.py file yet.

[Eric Seidel (no email)]

Comment on attachment 40078 [details]
v1

Was this diff edited by hand?  It failed to apply correctly...  See attachment on https://bugs.webkit.org/show_bug.cgi?id=29622 for the log.

[Tony Chang]

(In reply to comment #10)
> (From update of attachment 40078 [details])
> Was this diff edited by hand?  It failed to apply correctly...  See attachment
> on https://bugs.webkit.org/show_bug.cgi?id=29622 for the log.

I made the diff using "git diff --no-prefix --relative".  I guess I should just use git-bugzilla-tool.

[Adam Langley]

Will land manually.

[Adam Langley]

Landed.

[Adam Langley]

Changed by: [e-mail]
Changed at: Fri 25 Sep 2009 16:19:03
Branch: trunk
Revision: 48777

Changed files:

WebCore/ChangeLog
WebCore/WebCore.gyp/WebCore.gyp
Comments:
2009-09-24  Tony Chang  <[e-mail]>

        Reviewed by David Levin.

        Add a gyp variable to allow building a debug webcore without debug
        symbols.  This allows for faster compile, link, and gdb times.

        https://bugs.webkit.org/show_bug.cgi?id=29721

        No new tests, build config change.

        * WebCore.gyp/WebCore.gyp:
Properties: