Summary: | [V8] Fixed bindings build after http://trac.webkit.org/changeset/48701 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Vitaly Repeshko <vitalyr> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, ggaren, pfeldman, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 29701 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Vitaly Repeshko
2009-09-24 06:49:41 PDT
Created attachment 40064 [details]
patch
Comment on attachment 40064 [details]
patch
r=me.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/V8AbstractEventListener.cpp M WebCore/bindings/v8/V8AbstractEventListener.h M WebCore/bindings/v8/V8LazyEventListener.cpp M WebCore/bindings/v8/V8LazyEventListener.h M WebCore/bindings/v8/V8WorkerContextEventListener.cpp M WebCore/bindings/v8/V8WorkerContextEventListener.h M WebCore/bindings/v8/custom/V8CustomEventListener.cpp M WebCore/bindings/v8/custom/V8CustomEventListener.h M WebCore/bindings/v8/custom/V8DOMApplicationCacheCustom.cpp M WebCore/dom/EventTarget.h Committed r48720 Sam, Geoffrey, can we coordinate landing these a bit better? Maybe a warning and a tiny bit of time to come up with a mirroring V8 patch? Not good when Chromium bot gets broken overnight. Sorry, I didn't know that was expected. The feedback I've gotten from Chrome developers thus far has been "pay no attention to supporting v8 -- we'll take care of it." Has that changed? Well, it's more of a courtesy request rather than a demand to fix V8 bindings :) We will fix V8 stuff, but it's still pretty hard to drop everything and deal with a large change like this landing without a warning. I imagine that since we have a Chromium builder on the waterfall, it's all part of keeping the tree green? I'm having trouble pinning down exactly what your'e saying. > Maybe a warning This sounds like you're asking for a personal email, in addition to the public bug I posted patches to. I can do that. Should I email you directly? > a tiny bit of time to come up with a mirroring V8 patch This sounds like you're asking for a policy that WebKit changes don't land until the v8 tree is ready. I don't think that's a good idea. > Not good when Chromium bot gets broken overnight. This sounds like you're asking for check-ins only to happen during Pacific time daylight hours. I don't think that's a good idea. > Well, it's more of a courtesy request rather than a demand to fix V8 bindings :) This sounds like you're saying that it's not my responsibility to keep the v8 bindings working. That's consistent with what other Chrome developers have said. > We will fix V8 stuff, but it's still pretty hard to drop everything and deal with a large change like this landing This sounds like you're saying that it's hard to maintain a separate JavaScript engine. I agree. > I imagine that since we have a Chromium builder on the waterfall, it's all part of keeping the tree green? This sounds like you're saying that it should be my responsibility to keep the v8 bindings working. I don't think that's a good idea. That's not consistent with what other Chrome developers have said. Landed as http://trac.webkit.org/changeset/48720. (In reply to comment #7) In response to paragraph 1, first sentence... wait, wait. I really don't want this to become controversial, offensive, or stress-inducing in any way. If you feel like you have to defend yourself, please don't -- I didn't mean to attack you. If you don't think you can give a heads-up and wait before landing things that will break V8 bindings, that's fine. I understand. You don't have to. I subscribed to you guys on bugzilla, so I'll try to watch and react faster. (In reply to comment #9) I'm sorry for sounding defensive. I know it must be hard to maintain a forked JavaScript engine. I wish you didn't have to. In the future, I'll give you a heads-up if I can. |