Bug 296921
| Summary: | REGRESSION(2.48.5): [WPE][GTK] Does not compile on ARMv7 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | development.slash |
| Component: | WPE WebKit | Assignee: | WebKitGTK+ bugs <bugs-noreply> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aperez, bugs-noreply, meissl.christian, skandigraun |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | Other | ||
| OS: | Linux | ||
development.slash
Since the release 2.48.5 we get a lowering error in arm.rb regarding the addq instruction. As a workaround we added a case for addq into arm.rb. Here is the compilation error on arm-v7a:
cd /data/bsp/platform-board1/build-target/wpewebkit-2.48.5-build/JavaScriptCore/DerivedSources && /data/bsp/platform-board1/sysroot-host/usr/bin/cmake -E env CMAKE_CXX_COMPILER_ID=GNU GCC_OFFLINEASM_SOURCE_MAP=OFF /usr/bin/ruby /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb -I/data/bsp/platform-board1/build-target/wpewebkit-2.48.5-build/JavaScriptCore/DerivedSources/ /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/llint/LowLevelInterpreter.asm /data/bsp/platform-board1/build-target/wpewebkit-2.48.5-build/bin/LLIntOffsetsExtractor /data/bsp/platform-board1/build-target/wpewebkit-2.48.5-build/JavaScriptCore/DerivedSources/LLIntAssembly.h normal --binary-format=ELF && /data/bsp/platform-board1/sysroot-host/usr/bin/cmake -E touch_nocreate /data/bsp/platform-board1/build-target/wpewebkit-2.48.5-build/JavaScriptCore/DerivedSources/LLIntAssembly.h
/data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/ast.rb:1004:in `lowerDefault': Unhandled opcode addq at WebAssembly.asm:739 (due to WebAssembly.asm:739) (LoweringError)
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/arm.rb:999:in `lowerARMCommon'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/arm.rb:483:in `lowerARMv7'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/backends.rb:126:in `lower'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/backends.rb:188:in `block in lower'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/backends.rb:186:in `each'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/backends.rb:186:in `lower'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:399:in `block (5 levels) in <main>'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:101:in `inAsm'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:398:in `block (4 levels) in <main>'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/settings.rb:201:in `emitCodeInConfiguration'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:396:in `block (3 levels) in <main>'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/settings.rb:107:in `forSettings'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:381:in `block (2 levels) in <main>'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:377:in `each'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:377:in `block in <main>'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:361:in `open'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:361:in `<main>'
/data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/ast.rb:1004:in `lowerDefault': Unhandled opcode addq at WebAssembly.asm:739 (RuntimeError)
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/arm.rb:999:in `lowerARMCommon'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/arm.rb:483:in `lowerARMv7'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/backends.rb:126:in `lower'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/backends.rb:188:in `block in lower'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/backends.rb:186:in `each'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/backends.rb:186:in `lower'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:399:in `block (5 levels) in <main>'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:101:in `inAsm'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:398:in `block (4 levels) in <main>'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/settings.rb:201:in `emitCodeInConfiguration'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:396:in `block (3 levels) in <main>'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/settings.rb:107:in `forSettings'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:381:in `block (2 levels) in <main>'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:377:in `each'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:377:in `block in <main>'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:361:in `open'
from /data/bsp/platform-board1/build-target/wpewebkit-2.48.5/Source/JavaScriptCore/offlineasm/asm.rb:361:in `<main>'
ninja: build stopped: subcommand failed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
This commit has a backported fix that introduced the usage of “addq” in WebAssembly.asm:
https://github.com/WebKit/WebKit/commit/846b3f034f0021a0e45358b904682bc3de367605
Adrian Perez
We have pushed a fix for this in commit https://github.com/WebKit/WebKit/commit/7999ecd5ee4ea3123f7e75634d2bc57f57ca7070
Gyorgy Sarvari
*** Bug 297062 has been marked as a duplicate of this bug. ***