Bug 296916
| Summary: | AXObjectCache should have a smaller public interface | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dominic Mazzoni <dm_mazzoni> |
| Component: | New Bugs | Assignee: | Dominic Mazzoni <dm_mazzoni> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Dominic Mazzoni
AXObjectCache is included from N source files outside of the accessibility/ directory, but AXObjectCache is so central to accessibility that it includes dozens of other files.
That caused a compile error for me because I tried to include Logging.h from a header, and there are separate Logging.h files in different modules that aren't all the same.
If we abstracted away the external interface from AXObjectCache we could dramatically reduce the chances that would happen. It'd also probably speed up the build for everyone.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/158100405>
Dominic Mazzoni
Fixed by a series of changes:
AX: move AXObjectCache::postNotification code inside the accessibility directory
https://bugs.webkit.org/show_bug.cgi?id=297150
AX: AXObjectCache should have an Inlines header file
https://bugs.webkit.org/show_bug.cgi?id=297217
AX: avoid including AXObjectCache.h from page/Chrome.h
https://bugs.webkit.org/show_bug.cgi?id=297384
AX: AXNotifications enum and AXComputedObjectAttributeCache can be extracted from AXObjectCache
https://bugs.webkit.org/show_bug.cgi?id=297469
*** This bug has been marked as a duplicate of bug 297217 ***