Summary: | Guard QX11Info include with Q_WS_X11 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Norbert Leser <norbert.leser> | ||||
Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, hausmann, kenneth, laszlo.gombos, ossy, tonikitoo, yongjun.zhang | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 27065 | ||||||
Attachments: |
|
Description
Norbert Leser
2009-09-23 05:19:56 PDT
Norbert, you don't need reviews for build fixes like this one :-) Feel free to commit! Just write "Unreviewed Qt build fix" in the ChangeLog Comment on attachment 39990 [details]
QX11Info patch
Kennth is right, but r=me
(In reply to comment #2) > (From update of attachment 39990 [details]) > Kennth is right, but r=me I don't have commit rights - thus, someone else please pick it up. The fix seems trivial, and in this case, I assume it is - still, these sort of changes can easily break the build on certain platforms, under certain conditions. I would caution to treat these as pass-through / non-review fixes. Comment on attachment 39990 [details] QX11Info patch Rejecting patch 39990 from commit-queue. kenneth.christiansen@openbossa.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. kenneth@webkit.org is an alias for kenneth.christiansen@openbossa.org Committer("Kenneth Rohde Christiansen", "kenneth@webkit.org"), Should I add both or ? Comment on attachment 39990 [details]
QX11Info patch
Let's try again! I changed my bugzilla e-mail.
Comment on attachment 39990 [details] QX11Info patch Clearing flags on attachment: 39990 Committed r48676: <http://trac.webkit.org/changeset/48676> All reviewed patches have been landed. Closing bug. |