Bug 29676

Summary: [Qt] QWebPage::setView() changes incorrectly the viewport size of a QWebGraphicsItem
Product: WebKit Reporter: J-P Nurmi <jpnurmi>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
QWebPage::setView(): check if the view actually changes none

Description J-P Nurmi 2009-09-23 04:21:28 PDT 
Prevent QWebPage::setView() from changing the viewport size on the fly in case the view doesn't actually change. QWebPage::setView() is called upon every QWebGraphicsItem::hoverMoveEvent(), which forces the viewport size to be equal to the size of the whole graphics view. The geometry of a single graphics item rarely matches the geometry of the whole graphics view.
Comment 1 J-P Nurmi 2009-09-23 04:28:28 PDT 
Created attachment 39987 [details]
QWebPage::setView(): check if the view actually changes
Comment 2 Simon Hausmann 2009-09-23 14:40:49 PDT 
Comment on attachment 39987 [details]
QWebPage::setView(): check if the view actually changes

r=me. Good catch :)
Comment 3 WebKit Commit Bot 2009-09-23 18:02:11 PDT 
Comment on attachment 39987 [details]
QWebPage::setView(): check if the view actually changes

Clearing flags on attachment: 39987

Committed r48693: <http://trac.webkit.org/changeset/48693>
Comment 4 WebKit Commit Bot 2009-09-23 18:02:14 PDT 
All reviewed patches have been landed.  Closing bug.