Summary: | Crash observed while loading plugin content | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | rashmi <rashmi.s> | ||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
URL: | http://waplabdc.nokia-boston.com/browser/users/cwrt/BAT/index.html | ||||||
Attachments: |
|
Description
rashmi
2009-09-22 23:48:30 PDT
Created attachment 39983 [details]
qtWebkit fix for mp3 play crash
null check added when plugin response failed to catch and m_pluginView tried to access again
Comment on attachment 39983 [details] qtWebkit fix for mp3 play crash Why isn't this already caught by the null-check 4 lines above the didReciveData call? // We re-check here as the plugin can have been created if (m_pluginView) { if (!m_hasSentResponseToPlugin) { m_pluginView->didReceiveResponse(loader->response()); // didReceiveResponse sets up a new stream to the plug-in. on a full-page plug-in, a failure in // setting up this stream can cause the main document load to be cancelled, setting m_pluginView // to null if (!m_pluginView) return; m_hasSentResponseToPlugin = true; } m_pluginView->didReceiveData(data, length); } Also, for future reference: - Do patches based on the root of the webkit source tree, not inside WebKit - Follow the QtWebKit bug reporting guidlines http://trac.webkit.org/wiki/QtWebKitContrib#ReportingBugs - In particular, choose the right component and add the Qt keyword - You can safely leave out comments like the one in this patch, that's what the changelog/commit message is for Thank you for the review comments. I have branched webkit in which prior to my fix the crash was still reproducible with QtLauncher. I will close this bug once I find that this crash is not reproducible on the latest webkit code. Comment on attachment 39983 [details] qtWebkit fix for mp3 play crash Indeed, this crash was fixed in http://trac.webkit.org/changeset/45814 |