Bug 296688

Summary:	Wrong member access due to DECLARE_VISIT_CHILDREN macro
Product:	WebKit	Reporter:	Johann Klähn <johann>
Component:	JavaScriptCore	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Johann Klähn

Reported 2025-07-30 03:10:38 PDT

The definition of the 'DECLARE_VISIT_CHILDREN' macro contains declarations with different access specifiers. Since it ends with the 'public' access specifier, it should only be used within the public section of the surrounding class. Otherwise, it will inadvertently change members declared after the use of the macro to be public.

Attachments
Add attachment proposed patch, testcase, etc.

Johann Klähn

Comment 1 2025-07-30 03:16:23 PDT

Pull request: https://github.com/WebKit/WebKit/pull/48712

EWS

Comment 2 2025-07-30 21:08:40 PDT

Committed 298066@main (b0498801e751): <https://commits.webkit.org/298066@main> Reviewed commits have been landed. Closing PR #48712 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2025-07-30 21:09:15 PDT

<rdar://problem/157176534>

Note You need to log in before you can comment on or make changes to this bug.