Summary: | [GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric, oliver | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Martin Robinson
2009-09-22 15:16:04 PDT
Created attachment 39957 [details]
Patch for this issue
Comment on attachment 39957 [details]
Patch for this issue
No way to test this? Please either add a test or explain in the ChangeLog why it's impossible/impractical.
Please use a real email address for the ChangeLog too. :)
Created attachment 39964 [details]
Fix for this issue and additional test
Doh, and it's not even Monday. I've added a test to the existing manual image cursor test for Gtk. I will also be attaching the cursor image file to this bug, as I believe that binary data from git diffs is not compatible with svn.
Created attachment 39965 [details]
Image file used in new manual-test
Comment on attachment 39964 [details]
Fix for this issue and additional test
OK. If you want the commit-bot to handle this for you, you'll need to request addition to the commit-queue with commit-queue=?.
(In reply to comment #5) > OK. If you want the commit-bot to handle this for you, you'll need to request > addition to the commit-queue with commit-queue=?. It may need to be manually committed since I'm adding a binary file and my patch is a git commit. Should I commit-queue=? it anyhow? Comment on attachment 39964 [details]
Fix for this issue and additional test
svn-apply should be able to handle this patch. Adding cq+
Comment on attachment 39964 [details] Fix for this issue and additional test Rejecting patch 39964 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=39964 from bug 29654 failed to download and apply. patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/manual-tests/gtk/cursor-image.html patch: **** Only garbage was found in the patch input. patching file WebCore/platform/graphics/gtk/ImageGtk.cpp Logging in as eseidel@chromium.org... Rejecting patch 39964 from commit-queue. Hum... I guess svn-apply can't handle this patch. Committed r48888 Thank you Oliver. |