Bug 296525
| Summary: | [GLIB] REGRESSION(297498@main): Build breaks on !ENABLE(2022_GLIB_API) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jim Mason <jmason> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jim Mason
webkit/Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp:40:25: error: member access into incomplete type 'WebKit::JavaScriptEvaluationResult'
40 | jsValue = result.toJSC();
| ^
webkit/Source/WebKit/UIProcess/API/glib/WebKitJavascriptResultPrivate.h:26:7: note: forward declaration of 'WebKit::JavaScriptEvaluationResult'
26 | class JavaScriptEvaluationResult;
| ^
webkit/Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp:53:18: error: no matching constructor for initialization of 'WebKitJavascriptResult' (aka '_WebKitJavascriptResult')
53 | new (result) WebKitJavascriptResult(serializedScriptValue);
| ^ ~~~~~~~~~~~~~~~~~~~~~
webkit/Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp:37:8: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'WebCore::SerializedScriptValue' to 'const _WebKitJavascriptResult' for 1st argument
37 | struct _WebKitJavascriptResult {
| ^~~~~~~~~~~~~~~~~~~~~~~
webkit/Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp:37:8: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'WebCore::SerializedScriptValue' to '_WebKitJavascriptResult' for 1st argument
37 | struct _WebKitJavascriptResult {
| ^~~~~~~~~~~~~~~~~~~~~~~
webkit/Source/WebKit/UIProcess/API/glib/WebKitJavascriptResult.cpp:38:14: note: candidate constructor not viable: no known conversion from 'WebCore::SerializedScriptValue' to 'WebKit::JavaScriptEvaluationResult' for 1st argument
38 | explicit _WebKitJavascriptResult(WebKit::JavaScriptEvaluationResult&& result)
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Reverting 297498@main clears the issue.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Jim Mason
Fixed by 298116@main. Closing.