Summary: | [GTK] Add WEBKIT_LOAD_ERROR status | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xan Lopez <xan.lopez> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | jmalonzo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Xan Lopez
2009-09-22 09:09:20 PDT
Created attachment 39926 [details]
loaderror.diff
Comment on attachment 39926 [details]
loaderror.diff
I like the idea. You have my half r+. I'll take this into consideration when re-submitting sub-resource load tracking.
(In reply to comment #1) > Created an attachment (id=39926) [details] > loaderror.diff Does this only appply to committed load errors? (In reply to comment #3) > (In reply to comment #1) > > Created an attachment (id=39926) [details] [details] > > loaderror.diff > > Does this only appply to committed load errors? Not really, when a URL does not exist we'll go from provisional to error directly. Why? BTW, I'm thinking that WEBKIT_LOAD_FAIL might be a better name than WEBKIT_LOAD_ERROR, since the dispatch is called didFailLoad. Opinions? :) (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #1) > > > Created an attachment (id=39926) [details] [details] [details] > > > loaderror.diff > > > > Does this only appply to committed load errors? > > Not really, when a URL does not exist we'll go from provisional to error > directly. Why? > > BTW, I'm thinking that WEBKIT_LOAD_FAIL might be a better name than > WEBKIT_LOAD_ERROR, since the dispatch is called didFailLoad. Opinions? :) On the other hand the existing signal is called 'load-error', hmmm... Naming things sucks. Comment on attachment 39926 [details] loaderror.diff (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > (In reply to comment #1) > > > > Created an attachment (id=39926) [details] [details] [details] [details] > > > > loaderror.diff > > > > > > Does this only appply to committed load errors? > > > > Not really, when a URL does not exist we'll go from provisional to error > > directly. Why? > > > > BTW, I'm thinking that WEBKIT_LOAD_FAIL might be a better name than > > WEBKIT_LOAD_ERROR, since the dispatch is called didFailLoad. Opinions? :) I prefer LOAD_FAIL. > On the other hand the existing signal is called 'load-error', hmmm... Naming > things sucks. Can we break API? Either way, r=me. |