Bug 29641

Summary:

nuke HTMLBaseFontElement interface

Product:

WebKit

Reporter:

Anne van Kesteren <annevk>

Component:

DOM

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED WORKSFORME

Severity:

Normal

CC:

ap, arv, buildbot, cdumez, commit-queue, eflews.bot, esprehn+autocc, gtk-ews, gyuyoung.kim, gyuyoung.kim, mmaxfield, Ms2ger, philn, rakuco, rego+ews, rniwa, silviapf, xan.lopez, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Provisional patch	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2	none
Provisional patch	none
Patch	rniwa: review-, webkit-ews: commit-queue-
Provisional patch	none

Anne van Kesteren

Reported 2009-09-22 07:10:48 PDT

Opera recently removed rendering support for the <basefont> element to be in line with Gecko/WebKit, but the interface is still there because it is still in Gecko/WebKit. Would it be possible to clean this up or are we forever stuck with it? (I realize we're forever stuck with the quirk in the parser.) Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=518110

Attachments
Provisional patch (162.93 KB, patch) 2013-05-15 09:51 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (609.89 KB, application/zip) 2013-05-15 14:00 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (588.49 KB, application/zip) 2013-05-15 14:05 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (571.37 KB, application/zip) 2013-05-15 15:04 PDT, Build Bot	no flags	Details
Provisional patch (165.61 KB, patch) 2013-05-16 11:39 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch (166.27 KB, patch) 2013-05-22 13:41 PDT, Zan Dobersek	rniwa: review- webkit-ews: commit-queue-	Details Formatted Diff Diff
Provisional patch (138.01 KB, patch) 2013-09-27 08:58 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 1 2010-04-19 12:24:23 PDT

Gecko did this.

Silvia Pfeiffer

Comment 2 2013-04-22 04:58:01 PDT

Blink: http://code.google.com/p/chromium/issues/detail?id=231042

Zan Dobersek

Comment 3 2013-05-06 05:37:33 PDT

Would removing this break anything downstream of the Apple ports?

Timothy Hatcher

Comment 4 2013-05-07 20:37:26 PDT

Nuke it.

Zan Dobersek

Comment 5 2013-05-15 09:51:00 PDT

Created attachment 201847 [details] Provisional patch

WebKit Commit Bot

Comment 6 2013-05-15 09:54:00 PDT

Please wait for approval from timothy@apple.com (or another member of the Apple Safari Team) before submitting because this patch contains changes to the Apple Mac WebKit.framework public API.

Early Warning System Bot

Comment 7 2013-05-15 10:01:45 PDT

Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/480105

Early Warning System Bot

Comment 8 2013-05-15 10:07:56 PDT

Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/470587

Build Bot

Comment 9 2013-05-15 10:33:57 PDT

Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/467943

EFL EWS Bot

Comment 10 2013-05-15 10:42:28 PDT

Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/473579

EFL EWS Bot

Comment 11 2013-05-15 10:46:35 PDT

Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/477544

kov's GTK+ EWS bot

Comment 12 2013-05-15 12:21:19 PDT

Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/470615

Build Bot

Comment 13 2013-05-15 14:00:19 PDT

Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/474623 New failing tests: http/tests/security/cross-frame-access-put.html http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html http/tests/security/cross-frame-access-get.html

Build Bot

Comment 14 2013-05-15 14:00:24 PDT

Created attachment 201878 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.2

Build Bot

Comment 15 2013-05-15 14:04:58 PDT

Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/471702 New failing tests: http/tests/security/cross-frame-access-put.html

Build Bot

Comment 16 2013-05-15 14:05:04 PDT

Created attachment 201879 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2

Build Bot

Comment 17 2013-05-15 14:22:04 PDT

Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/473649

Build Bot

Comment 18 2013-05-15 15:04:36 PDT

Comment on attachment 201847 [details] Provisional patch Attachment 201847 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/481204 New failing tests: http/tests/security/cross-frame-access-put.html

Build Bot

Comment 19 2013-05-15 15:04:43 PDT

Created attachment 201886 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2

Zan Dobersek

Comment 20 2013-05-16 11:39:49 PDT

Created attachment 201978 [details] Provisional patch

Early Warning System Bot

Comment 21 2013-05-16 14:33:04 PDT

Comment on attachment 201978 [details] Provisional patch Attachment 201978 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/491083

Early Warning System Bot

Comment 22 2013-05-16 14:36:22 PDT

Comment on attachment 201978 [details] Provisional patch Attachment 201978 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/488110

EFL EWS Bot

Comment 23 2013-05-16 14:43:07 PDT

Comment on attachment 201978 [details] Provisional patch Attachment 201978 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/480562

EFL EWS Bot

Comment 24 2013-05-16 14:43:21 PDT

Comment on attachment 201978 [details] Provisional patch Attachment 201978 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/486168

Build Bot

Comment 25 2013-05-16 14:48:32 PDT

Comment on attachment 201978 [details] Provisional patch Attachment 201978 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/487157

kov's GTK+ EWS bot

Comment 26 2013-05-16 15:15:46 PDT

Comment on attachment 201978 [details] Provisional patch Attachment 201978 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/480573

Build Bot

Comment 27 2013-05-16 22:45:09 PDT

Comment on attachment 201978 [details] Provisional patch Attachment 201978 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/484584

Zan Dobersek

Comment 28 2013-05-22 13:41:52 PDT

Created attachment 202619 [details] Patch

Zan Dobersek

Comment 29 2013-05-22 13:46:27 PDT

(In reply to comment #28) > Created an attachment (id=202619) [details] > Patch That's the patch, all the build failures are due to stale bindings that are not updated after the interface is removed and are still including the JSHTMLBaseFont.h header.

Early Warning System Bot

Comment 30 2013-05-22 13:51:30 PDT

Comment on attachment 202619 [details] Patch Attachment 202619 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/574024

Early Warning System Bot

Comment 31 2013-05-22 13:53:45 PDT

Comment on attachment 202619 [details] Patch Attachment 202619 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/582026

Build Bot

Comment 32 2013-05-22 14:05:37 PDT

Comment on attachment 202619 [details] Patch Attachment 202619 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/542267

EFL EWS Bot

Comment 33 2013-05-22 14:09:39 PDT

Comment on attachment 202619 [details] Patch Attachment 202619 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/579014

Build Bot

Comment 34 2013-05-22 14:18:58 PDT

Comment on attachment 202619 [details] Patch Attachment 202619 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/538254

kov's GTK+ EWS bot

Comment 35 2013-05-22 14:20:50 PDT

Comment on attachment 202619 [details] Patch Attachment 202619 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/582033

EFL EWS Bot

Comment 36 2013-05-22 21:04:19 PDT

Comment on attachment 202619 [details] Patch Attachment 202619 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/625033

Erik Arvidsson

Comment 37 2013-05-23 02:50:18 PDT

It seems like this patch is removing support for basefont in the parser. Both Gecko and Blink only removed the interface so <basefont> maps to HTMLElement and not HTMLUnknownElement.

Ryosuke Niwa

Comment 38 2013-08-01 20:33:39 PDT

Comment on attachment 202619 [details] Patch r- since this patch doesn't build.

Zan Dobersek

Comment 39 2013-09-27 08:58:12 PDT

Created attachment 212813 [details] Provisional patch Here's the patch that makes the basefont tag fall back to HTMLUnknownElement and removes the HTMLBaseFontElement interface entirely from the source tree. Unfortunately none of the build systems can complete an incremental build with this patch applied since the generated JSC bindings source code that indirectly includes the removed HTMLBaseFontElement.h header doesn't get regenerated. So this is pretty much blocked until a coordinated effort can be made to enforce clean builds after this lands, or until a mechanism is introduced that would somehow make it possible to have build-webkit enforce clean builds on specific commits.

Anne van Kesteren

Comment 40 2017-08-22 05:05:18 PDT

Seems this got fixed somehow meanwhile. At least html/semantics/interfaces.html no longer suggests <basefont> triggers the old interface in Safari TP.

Chris Dumez

Comment 41 2017-08-22 13:05:30 PDT

(In reply to Anne van Kesteren from comment #40) > Seems this got fixed somehow meanwhile. At least > > html/semantics/interfaces.html > > no longer suggests <basefont> triggers the old interface in Safari TP. Likely fixed via Bug 161004.

Note You need to log in before you can comment on or make changes to this bug.