Bug 29630

Summary:

Some layout tests contain tab characters

Product:

WebKit

Reporter:

Shinichiro Hamaji <hamaji>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

sam

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch v1	sam: review-

Shinichiro Hamaji

Reported 2009-09-22 01:46:51 PDT

The following files contain tab characters. LayoutTests/fast/js/kde/resources/RegExp.js LayoutTests/fast/js/kde/resources/cast.js LayoutTests/fast/js/kde/resources/exceptions.js LayoutTests/fast/js/kde/resources/md5-1.js LayoutTests/fast/js/kde/resources/statements.js LayoutTests/fast/js/resources/regexp-extended-characters-crash.js Patch will come soon.

Attachments
Patch v1 (10.17 KB, patch) 2009-09-22 01:53 PDT, Shinichiro Hamaji	sam: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Shinichiro Hamaji

Comment 1 2009-09-22 01:53:03 PDT

Created attachment 39909 [details] Patch v1

Sam Weinig

Comment 2 2009-09-22 07:41:42 PDT

Comment on attachment 39909 [details] Patch v1 Tabs in layout tests is fine. There is no reason to land this change.

Shinichiro Hamaji

Comment 3 2009-09-22 13:49:18 PDT

(In reply to comment #2) > (From update of attachment 39909 [details]) > Tabs in layout tests is fine. There is no reason to land this change. OK, so, I'll propset allow-tabs for them when I move these files. Thanks for the review!

Note You need to log in before you can comment on or make changes to this bug.