Bug 296148
| Summary: | Use Copy Files build phases instead of rsync to copy testapiScripts | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Vassili Bykov <v_bykov> |
| Component: | JavaScriptCore | Assignee: | Vassili Bykov <v_bykov> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Vassili Bykov
rdar://151903358
In the existing JavaScriptCore.xcodeproj, the 'testapi' target includes a phase that runs rsync to copy the directory 'Source/JavaScriptCore/API/tests/testapiScripts' into the build product directory. 'testapi' tests expect the directory to be available side-by-side with the 'testapi' executable. In some internal build and packaging tools, this operation is not recognized and the copied directory is missing in the build artifacts. This causes 'testapi' test failures on internal test bots.
Instead, the files should be copied using Xcode's built-in 'Copy Files' build phase. That phase is recognized by the internal built infrastructure and the copied directory is present in the build artifacts in all appropriate configurations.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Vassili Bykov
Pull request: https://github.com/WebKit/WebKit/pull/48204
EWS
Committed 297740@main (9347e5999f88): <https://commits.webkit.org/297740@main>
Reviewed commits have been landed. Closing PR #48204 and removing active labels.