Bug 296133
| Summary: | [webkitapipy] Allowed selector names are ambiguous between classes, leading to false positives | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Elliott Williams
audit-spi only tracks selectors sent by a binary, and not the classes that receive those messages. This means that we may have allowed a selector which is an SPI method on one class, but API on another class. This is an `UnnecessaryAllowedName` verification error, and prompts us to remove the selector from the allowlist.
But we might be intending to bind to the SPI method, so it would be premature to remove it from the allowlist. We should instead make it possible to narrow the allowlist declaration to bind to the specific SPI method.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/48192
Radar WebKit Bug Importer
<rdar://problem/156617260>
EWS
Committed 298571@main (b9fa7bcf1170): <https://commits.webkit.org/298571@main>
Reviewed commits have been landed. Closing PR #48192 and removing active labels.