Bug 296072
| Summary: | Make WTF_MAKE_COMPACT_TZONE_ALLOCATED set allowCompactPointers and re-enable TZone compactness inheritance | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Degazio <d_degazio> |
| Component: | bmalloc | Assignee: | David Degazio <d_degazio> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ggaren, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Degazio
We previously tried to do this in https://bugs.webkit.org/show_bug.cgi?id=295215, but had to revert it due to an issue where relying on compactness being set for a type was causing some incorrect behavior in certain TZoned allocations. It turns out we were only setting allowCompactPointers for types that were WTF_MAKE_COMPACT_TZONE_OR_ISO_ALLOCATED, not WTF_MAKE_COMPACT_TZONE_ALLOCATED, so types in the latter category were seeing some amount of incorrect inheritance. This is an easy fix, so let's re-land the inheritance changes.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/155980834>
David Degazio
Pull request: https://github.com/WebKit/WebKit/pull/48133
EWS
Committed 297621@main (e4bf6e21542a): <https://commits.webkit.org/297621@main>
Reviewed commits have been landed. Closing PR #48133 and removing active labels.