Bug 296059
| Summary: | [MSE][GStreamer] update maximum buffer size after receiving first init segment | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Enrique Ocaña <eocanha> |
| Component: | New Bugs | Assignee: | Enrique Ocaña <eocanha> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Enrique Ocaña
The current SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment() code only calls SourceBufferPrivate::setMaximumBufferSize() on new init segments when the segment has (at least) a video track. Maximum buffer size is managed with high granularity in WPE by using the MSE_MAX_BUFFER_SIZE environment variable. For that reason, that call must happen independently of the kind of tracks present (at least on the WPE platform). This will ensure that the proper frame eviction code in SourceBufferPrivate::setMaximumBufferSize() is called in all cases.
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1534
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Enrique Ocaña
Pull request: https://github.com/WebKit/WebKit/pull/48121
EWS
Committed 297674@main (da13f3fd899e): <https://commits.webkit.org/297674@main>
Reviewed commits have been landed. Closing PR #48121 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/156307863>