Summary: | [Chromium] Fix the V8 bindings' handling of window.top | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nate Chapin <japhet> | ||||
Component: | WebCore Misc. | Assignee: | Nate Chapin <japhet> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, commit-queue, dglazkov, levin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Nate Chapin
2009-09-21 12:57:49 PDT
Created attachment 39865 [details]
patch
After rereading CodeGeneratorV8.pm, I found a usage of V8ReadOnly that I hadn't noticed before, so I won't be doing #3 as I had originally thought.
Adam is your man here. Comment on attachment 39865 [details]
patch
We can't allow shadowing of window.top without confusing Flash and other plug-ins. The correct solution here is to convince the JSC port not to mark |top| are replaceable, but that's a longer conversation. In the meantime, we should fix the LayoutTest. If this regression is in stable, we should backport this fix.
Thanks for the patch.
Comment on attachment 39865 [details] patch Clearing flags on attachment: 39865 Committed r48598: <http://trac.webkit.org/changeset/48598> All reviewed patches have been landed. Closing bug. |