Bug 29598
| Summary: | [Qt] QWebPage::createWindow() must call show() for target="blank" | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tor Arne Vestbø <vestbo> |
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | tonikitoo, yael |
| Priority: | P2 | Keywords: | Qt |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Other | ||
| OS: | OS X 10.5 | ||
Tor Arne Vestbø
This bug report originated from Nokia internal issue QT-1250
--- Description ---
Consider this implementation:
QWebPage * WebPage::createWindow(QWebPage::WebWindowType type)
{
qDebug() << Q_FUNC_INFO;
Q_UNUSED(type);
WebView * newView = new WebView();
newView->show(); // HERE
return newView->page();
}
show() must called for links with target="blank_", in other cases not. This is inconsistent and leads to confusion. See the second link in http://www.javascript-coder.com/window-popup/javascript-window-open-example1.html for an example.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yael
This bug is the same as https://bugs.webkit.org/show_bug.cgi?id=27285, in which I was told to not add the call to show().
Antonio Gomes
(In reply to comment #1)
> This bug is the same as https://bugs.webkit.org/show_bug.cgi?id=27285, in which
> I was told to not add the call to show().
can you dup it ?
Yael
*** This bug has been marked as a duplicate of bug 27285 ***