Bug 295960
| Summary: | WebCore::XMLMalloc::free() calls itself when xmlFree() is defined to call libmalloc free() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | New Bugs | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | commit-queue, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=295946 | ||
| Bug Depends on: | 296005 | ||
| Bug Blocks: | |||
David Kilzer (:ddkilzer)
WebCore::XMLMalloc::free() calls itself when xmlFree() is defined to call libmalloc free().
After libxml2 was updated to deprecate its custom allocator functions, xmlFree() was changed to a macro that calls free() instead.
However, due to the way WebCore::XMLMalloc::free() is defined, the compiler thought it would call itself via infinite recursion:
> All paths through this function will call itself
> XMLDocumentParserLibxml2.cpp:122
<rdar://155844722>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/48032
EWS
Committed 297381@main (e4ffdc6cd723): <https://commits.webkit.org/297381@main>
Reviewed commits have been landed. Closing PR #48032 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 296005