Bug 295845
| Summary: | Subspaces from WebCore generated classes were all erroneously named "T". | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | New Bugs | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Lam
This is because their name came from the WebCore::subspaceForImpl template function, which assumed that passed T to the macro ISO_SUBSPACE_INIT. The macro just takes "T" verbatim and converts it into a string for the name.
This patch refactors ISO_SUBSPACE_INIT into ISO_SUBSPACE_INIT_WITH_NAME, which will take an explicit name. WebCore::subspaceForImpl will now call ISO_SUBSPACE_INIT_WITH_NAME with an auto-generated classname in string form to be used as the Subspace name.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mark Lam
rdar://155708968
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/47944
EWS
Committed 297322@main (166e68b23001): <https://commits.webkit.org/297322@main>
Reviewed commits have been landed. Closing PR #47944 and removing active labels.